Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added method to duplicate predicate #3432

Merged
merged 24 commits into from
Jan 2, 2025
Merged

feat: added method to duplicate predicate #3432

merged 24 commits into from
Jan 2, 2025

Conversation

YaTut1901
Copy link
Contributor

@YaTut1901 YaTut1901 commented Nov 29, 2024 •
edited by arboleya
Loading

Release notes

In this release, we:

  • Added method fromInstance to the Predicate class

Summary

  • Added the method fromInstance to the Predicate class. This allows the consumer to create a new predicate instance with new configurable parameters and data.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:00pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:00pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 1:00pm

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024

@YaTut1901 is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the chore Issue is a chore label Nov 29, 2024
@YaTut1901 YaTut1901 mentioned this pull request Nov 29, 2024
Closed
4 tasks
@YaTut1901
Copy link
Contributor Author

@Torres-ssf @danielbate @petertonysmith94 hello, could you please check this implementation and if that fits point me which docs it should be documented in?

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3432 will degrade performances by 44.87%

Comparing YaTut1901:YaTut1901/chore/predicate-duplication-static (5f2e7a2) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master YaTut1901:YaTut1901/chore/predicate-duplication-static Change
❌ should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 91.2 ms -44.87%

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Dec 5, 2024

Thanks for the contribution! Before we can merge this, we need @YaTut1901 to sign the Fuel Labs Contributor License Agreement.

@Dhaiwat10
Copy link
Member

@YaTut1901 can you please fix the lint errors?

@Torres-ssf Torres-ssf added the feat Issue is a feature label Dec 11, 2024
Torres-ssf
Torres-ssf requested changes Dec 11, 2024
View reviewed changes
.changeset/gentle-toes-play.md Outdated Show resolved Hide resolved
@YaTut1901 YaTut1901 changed the title chore: added static method to duplicate predicate feat: added method to duplicate predicate Dec 13, 2024
@YaTut1901
Copy link
Contributor Author

hello @Torres-ssf @danielbate , may this PR be merged?

@Torres-ssf
Copy link
Contributor

hello @Torres-ssf @danielbate , may this PR be merged?

@YaTut1901 Please make sure to request a re-review after finishing applying the requested changes

@YaTut1901
Copy link
Contributor Author

@danielbate @petertonysmith94 approve please

arboleya
arboleya approved these changes Dec 18, 2024
View reviewed changes
.changeset/gentle-toes-play.md Show resolved Hide resolved
@arboleya arboleya enabled auto-merge (squash) January 2, 2025 11:54
@arboleya arboleya merged commit d5a696c into FuelLabs:master Jan 2, 2025
27 of 37 checks passed
@fuel-service-user fuel-service-user mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@YaTut1901 YaTut1901

Labels
cla:signed feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable creating a new predicate from an existing one
7 participants
@YaTut1901 @Dhaiwat10 @Torres-ssf @arboleya @danielbate @petertonysmith94 @nedsalk